8000 Typing Indicator fix after recent refactoring by rapterjet2004 · Pull Request #4041 · nextcloud/talk-android · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Typing Indicator fix after recent refactoring #4041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 2, 2024
Merged

Typing Indicator fix after recent refactoring #4041

merged 3 commits into from
Aug 2, 2024

Conversation

rapterjet2004
Copy link
Contributor
@rapterjet2004 rapterjet2004 commented Jul 30, 2024 •
edited
Loading

Note: Sending and Receiving messages works, but I'm not getting a stopped typing from the server. Nevertheless it seems to work as intended.

  • Test it

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@rapterjet2004
Got it working - Just need to test it out
b41f41f 
Signed-off-by: rapterjet2004 <juliuslinus1@gmail.com>
@rapterjet2004 rapterjet2004 self-assigned this Jul 30, 2024
@rapterjet2004
Seems to work - fixed adapter issue
515eced 
Signed-off-by: rapterjet2004 <juliuslinus1@gmail.com>
@rapterjet2004 rapterjet2004 requested a review from mahibi July 31, 2024 14:06
@rapterjet2004
lint
46cafd5 
Signed-off-by: rapterjet2004 <juliuslinus1@gmail.com>
@github-actions GitHub Actions
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings9090
Errors129129

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1111
Dodgy code7878
Internationalization33
Malicious code vulnerability33
Performance66
Security11
Total108108

@github-actions GitHub Actions
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4041-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@sowjanyakch sowjanyakch merged commit 8e8066d into master Aug 2, 2024
19 checks passed
@sowjanyakch sowjanyakch deleted the issue-4040 branch August 2, 2024 09:34
@AndyScherzinger AndyScherzinger added this to the 20.0.0 milestone Aug 2, 2024
@mahibi mahibi mentioned this pull request Sep 27, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mahibi mahibi mahibi approved these changes

@sowjanyakch sowjanyakch sowjanyakch approved these changes

Assignees

@rapterjet2004 rapterjet2004

Labels
None yet
Projects
None yet
Milestone
20.0.0
Development

Successfully merging this pull request may close these issues.

Typing Indicator is not working after recent Refactoring
4 participants
@rapterjet2004 @mahibi @sowjanyakch @AndyScherzinger
0