8000 remove jCenter + fix CI checks by mahibi · Pull Request #4020 · nextcloud/talk-android · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

remove jCenter + fix CI checks #4020 8000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jul 24, 2024
Merged

remove jCenter + fix CI checks #4020

merged 10 commits into from
Jul 24, 2024

Conversation

mahibi
Copy link
Collaborator
@mahibi mahibi commented Jul 24, 2024

resolve #2064

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

mahibi added 2 commits July 24, 2024 12:52
@mahibi
use converter-logansquare from mvncentral
688c351 
See

https://github.com/mannodermaus/retrofit-logansquare

https://mvnrepository.com/artifact/de.mannodermaus.retrofit2/converter-logansquare/1.4.1

However logansquare has to be replaced with more modern solutions soon!

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@mahibi
use FlexibleAdapter from Jitpack.io
0c9af5c 
See
davideas/FlexibleAdapter#768 (comment)

However FlexibleAdapter has to be removed soon (at best with Jetpack Compose)

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@mahibi mahibi added the 3. to review Waiting for reviews label Jul 24, 2024
@mahibi mahibi added this to the 20.0.0 milestone Jul 24, 2024
@mahibi mahibi self-assigned this Jul 24, 2024
@mahibi mahibi force-pushed the chore/2064/removeJCenter branch from d07ac7e to 840aedb Compare July 24, 2024 11:27
SystemKeeper
SystemKeeper approved these changes Jul 24, 2024
View reviewed changes
Copy link
@SystemKeeper SystemKeeper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't judge the code changes, but building works again for me! 🥳

mahibi added 8 commits July 24, 2024 14:14
@mahibi
remove lib com.novoda:merlin
d4e781a 
Doesn't seemed to be used anymore

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@mahibi
update verification metadata
dfa8ad4 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@mahibi
remove lib com.amulyakhare:com.amulyakhare.textdrawable
f19e1b8 
replace with own TextDrawable class

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@mahibi
remove gradlePluginPortal() as it was only used for jCenter
60944c2 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@mahibi
increase upper limit of heap memory
d8e349d 
otherwise
./gradlew clean assemble --refresh-dependencies

threw

e: java.lang.OutOfMemoryError: GC overhead limit exceeded

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@mahibi
remove commented out code
b6b98e2 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@mahibi
bump detekt maxIssues for now
6b3f789 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@mahibi
add version to androidx.compose.ui:ui-test-junit4
8f3ddca 
otherwise this will cause:

Execution failed for task ':app:generateGplayDebugAndroidTestLintModel'.
> Could not resolve all files for configuration ':app:gplayDebugAndroidTestRuntimeClasspath'.
   > Could not find androidx.compose.ui:ui-test-junit4:.
     Required by:
         project :app

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@mahibi mahibi force-pushed the chore/2064/removeJCenter branch from 6637b54 to 8f3ddca Compare July 24, 2024 12:14
@github-actions GitHub Actions
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings9090
Errors129129

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1111
Dodgy code8378
Internationalization33
Malicious code vulnerability33
Performance66
Security11
Total113108

@github-actions GitHub Actions
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4020-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@mahibi mahibi merged commit 1c8b108 into master Jul 24, 2024
18 of 19 checks passed
@mahibi mahibi deleted the chore/2064/removeJCenter branch July 24, 2024 12:33
@mahibi mahibi changed the title remove jCenter remove jCenter + fix CI checks Jul 24, 2024
@AndyScherzinger
Copy link
Member

I guess it needs back porting to 19.1 branch then @mahibi?

@mahibi
Copy link
Collaborator Author
mahibi commented Jul 25, 2024

/backport to stable-19.1

@backportbot backportbot bot mentioned this pull request Jul 25, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SystemKeeper SystemKeeper SystemKeeper approved these changes

@sowjanyakch sowjanyakch Awaiting requested review from sowjanyakch

@rapterjet2004 rapterjet2004 Awaiting requested review from rapterjet2004

Assignees

@mahibi mahibi

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
20.0.0
Development

Successfully merging this pull request may close these issues.

Remove or update libraries hosted in jCenter
3 participants
@mahibi @AndyScherzinger @SystemKeeper
0