NVSHAS-9993: Replace md5 by sha256 #2015
Conversation
| } | ||
|
|
||
| return GetMd5(base64.StdEncoding.EncodeToString(b)), nil | ||
| return strings.Replace(uuid.NewString(), "-", "", -1), nil |
There was a problem hiding this comment.
Should we change this to use a UUID instead?
However, using a UUID would make the ID non-deterministic and unpredictable.
I think it’s better to switch to SHA (e.g., SHA-256) so the ID remains consistent for the same input, while still being more secure than MD5.
There was a problem hiding this comment.
UUID is 128-bit number(typically represented as a 36-character string) & sha256 is 256-bit number.
Using sha256, instead of md5, to generate a UUID is not more secure.
There is no input parameter for GetGuid(). What does "ID remains consistent for the same input" mean?
GetGuid() should not return the same string
There was a problem hiding this comment.
you are right, I misunderstand the caller.
| } | ||
|
|
||
| return GetMd5(base64.StdEncoding.EncodeToString(b)), nil | ||
| return strings.Replace(uuid.NewString(), "-", "", -1), nil |
There was a problem hiding this comment.
you are right, I misunderstand the caller.
GetFedKvVer() in kv/upgrade.go is changed to return different value since 5.4.5.
One side effect of the md5 to sha256 replacement in multi-cluster setup is: |
No description provided.