8000 NVSHAS-9969: concurrent map writes results in enforcer component restart by williamlin-suse · Pull Request #1991 · neuvector/neuvector · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

NVSHAS-9969: concurrent map writes results in enforcer component restart #1991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 6, 2025
Merged

NVSHAS-9969: concurrent map writes results in enforcer component restart #1991

merged 2 commits into from
Jun 6, 2025

Conversation

williamlin-suse
Copy link
Contributor
@williamlin-suse williamlin-suse commented May 31, 2025 •
edited
Loading

enforcer issue has been fixed in prior version.
this PR is for improving logging & events aggregation found in customer's env

@williamlin-suse
NVSHAS-9969: concurrent map writes results in enforcer component rest…
6d65cbf 
…art (improving logging & events aggregation)
@williamlin-suse williamlin-suse requested a review from a team as a code owner May 31, 2025 00:30
holyspectral
holyspectral reviewed Jun 5, 2025
View reviewed changes
Copy link
Collaborator
@holyspectral holyspectral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good to me. It seems like now we will aggregate events if we've seen similar events more than the number of its replica, so we will have fewer events than before.

@williamlin-suse
NVSHAS-9969: concurrent map writes results in enforcer component rest…
311a438 
…art (improving logging & events aggregation)
holyspectral
holyspectral approved these changes Jun 6, 2025
View reviewed changes
Copy link
Collaborator
@holyspectral holyspectral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@williamlin-suse williamlin-suse merged commit 4c942ee into neuvector:main Jun 6, 2025
6 checks passed
@williamlin-suse williamlin-suse deleted the NVSHAS-9969 branch June 6, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holyspectral holyspectral holyspectral approved these changes

@jeffhuang4704 jeffhuang4704 Awaiting requested review from jeffhuang4704 jeffhuang4704 is a code owner automatically assigned from neuvector/controller

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@williamlin-suse @holyspectral
0