Experiment with custom partitioning #1932
Draft
+58
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1932 +/- ##
==========================================
- Coverage 84.72% 84.65% -0.08%
==========================================
Files 307 307
Lines 18695 18717 +22
Branches 3664 3669 +5
==========================================
+ Hits 15839 15844 +5
- Misses 2114 2130 +16
- Partials 742 743 +1 ☔ View full report in Codecov by Sentry. |
PhilipVinc
reviewed
Sep 25, 2024
| @@ -508,3 +510,51 @@ def device_count() -> int: | |||
| jax.device_count() if config.netket_experimental_sharding is True, and mpi.rank otherwise. | |||
| """ | |||
| return mpi.n_nodes * device_count_per_rank() | |||
|
|
|||
There was a problem hiding this comment.
can we move this function to a separate file?
|
bump? |
will require quite a bit more work to add the graidents. |
|
sigh. it would have been lovely |
|
For posterity. This is also missing the vmap rule. |
f6a2477 to
6e593ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1921.
Replaces shard_map with custom partitioning in the operators where it was used.
Infers the sharding from the inputs at compile time, instead of hardcoding it.