[UHxIZ8JO] Add CodeQL #186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dd6146f to
8c1c00a
Compare
2780cdb to
24ca169
Compare
We want to ignore PRs from this security researcher because they do not follow our private disclosure process. These PRs highlight that our code is exploitable before we've had the opportunity to fix it. However, we will take JLLeitschuh up on his suggestion to add https://github.com/github/codeql-action to run checks in the background.
The file was removed because it contained some vulnerabilities, and also because it was not used. It's also not used in APOC Extended.
46f1d98 to
afcf584
Compare
ncordon
reviewed
Oct 4, 2022
| * @author mh | ||
| * @since 17.01.14 | ||
| */ | ||
| public class ElementCounter { |
There was a problem hiding this comment.
Daniel has confirmed this was not used in extended
ncordon
reviewed
Oct 4, 2022
ncordon
approved these changes
Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CodeQL job is not decoupled from the main CI job. This is because CodeQL requires the artefacts to be built, and I didn't think it was worth to build the project twice.