5.0 add storage engine check #169
Conversation
| @Test(expected = RuntimeException.class) | ||
| public void testWarmupIsntAllowedWithOtherStorageEngines() { | ||
| testCall(session, "CALL apoc.warmup.run()", (r) -> {}); |
There was a problem hiding this comment.
Two nitpicks:
- We are missing a positive test
- Does this need to be an integration test (with a docker container)? Isn't there a way to test this with a unit test?
There was a problem hiding this comment.
I can add specific positive tests :)
The only way to test the negative case was to use an enterprise db, is there a way to get a test on that without docker? When I searched for setting up enterprise in other tests this was how they did it, but maybe I misunderstood? If so let me know.
There was a problem hiding this comment.
That is a really good question. I don't know how we do it inside the Neo4j repo really, but there should be a way to test the enterprise version without docker containers right?
I'm happy for us to merge this and then revisit if we get ahold of how to do it?
There was a problem hiding this comment.
That sounds good :) I can make a card for finding that out
a877b3a to
eb13787
Compare
The apoc.warmup.run procedure can only be used with the currently available storage engines.
I've added a checker for checking which storage engine currently is set via config. Let me know thoughts on this! It is also possible to only have the docs updated :)