Remove extended APOC config from core #166
Conversation
These were not used in either core or extended.
This will be added to extended repo instead.
As it is now only used in extended.
As it is now only used in extended.
| @@ -46,23 +44,15 @@ | |||
| import static org.neo4j.configuration.GraphDatabaseSettings.transaction_logs_root_path; | |||
|
|
|||
| public class ApocConfig extends LifecycleAdapter { | |||
| public static final String SUN_JAVA_COMMAND = "sun.java.command"; | |||
| protected static final String SUN_JAVA_COMMAND = "sun.java.command"; | |||
| public static final String APOC_IMPORT_FILE_ENABLED = "apoc.import.file.enabled"; | |||
| public static final String APOC_EXPORT_FILE_ENABLED = "apoc.export.file.enabled"; | |||
| public static final String APOC_IMPORT_FILE_USE_NEO4J_CONFIG = "apoc.import.file.use_neo4j_config"; | |||
| public static final String APOC_TTL_SCHEDULE = "apoc.ttl.schedule"; | |||
There was a problem hiding this comment.
Why are some TTL configs still in core? I thought all TTL procedures were in extended
There was a problem hiding this comment.
The reason I kept this as well as some UUID constant here was because of them being used in the file ApocSettings.java. I also tried out to move those settings to a ExtendedApocSettings file in extended, but then I would have to copy over all the code under // copy apoc settings from neo4j.conf for legacy support in ApocConfig to the ExtendedApocConfig as well if we want to keep the old behaviour.
I'm not sure if this legacy support is really needed in 5.x though as the comment in ApocSettings sounds a bit like that is something to make it easier for people to use the 3.x way in 4.x. If we think we can get rid of it all together, I could move over those constants as well as do further cleanup.
There was a problem hiding this comment.
Ah okay, I think the main thing for me is that it feels strange to have extended settings still in core. It might be nice to see if it is possible to remove the legacy stuff so core can move these out :) maybe ask the team?
Support for apoc config in Neo4j config file will be dropped.
Default values are now handled directly in ApocConfig.java
464e71c to
c924bf0
Compare
Parts of the APOC config was only used from extended (or in some cases fully unused). This PR removes them from core, while neo4j-contrib/neo4j-apoc-procedures#3157 introduce corresponding config to the extended. repo. It also removes the possibility to have APOC config in the neo4j.conf file