8000 Dashboard: Replace views with file count by joppiesaus · Pull Request #356 · neocities/neocities · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Dashboard: Replace views with file count #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Dashboard: Replace views with file count #356

wants to merge 1 commit into from

Conversation

joppiesaus
Copy link
Contributor

Fixes #355. I wasn't sure how to incorporate the amount of files. A <li> could also simply be added, or perhaps it should be somewhere else. I don't know. If it's merged it looks like this:
Selection_637

Take this commit as an idea and not strictly as a correct implementation.

Have a great day everyone! 😄

@joppiesaus
Dashboard: Replace views with file count
6163e87 
Fixes neocities#355. I wasn't sure how to incorporate the amount of files. A li
could also simply be added, or perhaps it should be somewhere else.
Take this commit as an idea and not strictly as a correct implementation.
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 61.685% when pulling 6163e87 on joppiesaus:fileCounterPatch1 into f33f661 on neocities:master.

@jackomix
Copy link

I suggest having a note when the number of files are over 500 that you can't download your site (and maybe a brief explanation as a tooltip). I only found out because I checked the source code when I didn't know why my download site button was gone.
(Also, to Kyle, I think the limit should be raised. It's very possible for a personal site to go over 500 files, even if it all adds up to less than 10mb (writing, blog posts, pages, art, songs, etc). Unless there's a factor I haven't thought of.)

@M-Valentino
Copy link
Contributor

(Also, to Kyle, I think the limit should be raised. It's very possible for a personal site to go over 500 files, even if it all adds up to less than 10mb (writing, blog posts, pages, art, songs, etc). Unless there's a factor I haven't thought of.)_

I know this is an old comment but, if you go through Neocitie's sitemap, it is quite large in that it includes subsections for users' sites.
https://neocities.org/sitemap/index.xml.gz

Maybe limiting the maximum number of files has to do with sitemapping bandwidth costs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

File counter
4 participants
@joppiesaus @coveralls @jackomix @M-Valentino
0