[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor trajectories plot #738

Draft
wants to merge 29 commits into
base: master
Choose a base branch
from
Draft

Refactor trajectories plot #738

wants to merge 29 commits into from

Conversation

ivan-aksamentov
Copy link
Member

Related issues and PRs

Description

Refactor and cleanup of the trajectories plot (aka DeterminitsticLinePlot).

Impacted Areas in the application

Testing

@ivan-aksamentov
refactor: move and rename DeterministicLinePlot to ResultsTrajectorie…
0c0d849 
…sPlot
@ivan-aksamentov
refactor: temporarily move formatter functions into component body
477d689
@ivan-aksamentov
refactor: reduce duplication, improve readability
d94ae06
@ivan-aksamentov
refactor: reformat duplicated code for clarity
284a22a
@ivan-aksamentov
refactor: clarify the intent by using a sort function
6cd3dfa
@ivan-aksamentov
refactor: temporarily replace iterated value with array access for cl…
c431dab 
…arity
@ivan-aksamentov
refactor: select only necessary scenario state
c3845ff
@ivan-aksamentov
fix: don't take the middle into account
3458257
@ivan-aksamentov
fix: naming conventions
ab71ef2
@ivan-aksamentov
refactor: accept a tuple in sort2
5ccbfc0
@ivan-aksamentov
refactor: rename sort2 to sortPair
5630c7d
@ivan-aksamentov
refactor: name variables
f65bbea
@ivan-aksamentov
refactor: name functions
1146242
@ivan-aksamentov
refactor: extract variable
831812e
@ivan-aksamentov
refactor: organize verifyTuple function
9447215
@ivan-aksamentov
refactor: move verify tuple function closer to usage
fede79f
@ivan-aksamentov
refactor: replace duplication with a loop
c734c45
@ivan-aksamentov
fix: replace wrong functor
5ecc051
@ivan-aksamentov
refactor: rename function to clarify intent
0cebafa
@vercel
Copy link
vercel bot commented Jun 11, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/covid19-scenarios/covid19-scenarios/ippnuznyw
✅ Preview: https://covid19-scenarios-git-refactor-trajectories-plot.covid19-scenarios.vercel.app

@vercel vercel bot temporarily deployed to Preview June 12, 2020 22:33 Inactive
@codeclimate
Copy link
codeclimate bot commented Jun 12, 2020

Code Climate has analyzed commit 290b963 and detected 0 issues on this pull request.

View more on Code Climate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ivan-aksamentov