refactor: rename field to next_gas_price #9641
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pugachAG
requested changes
Oct 6, 2023
core/primitives/src/block_header.rs
Outdated
| @@ -1044,13 +1044,13 @@ impl BlockHeader { | |||
| } | |||
|
|
|||
| #[inline] | |||
| pub fn gas_price(&self) -> Balance { | |||
| pub fn next_gas_price(&self) -> Balance { | |||
| match self { | |||
| BlockHeader::BlockHeaderV1(header) => header.inner_rest.gas_price, | |||
There was a problem hiding this comment.
Let's keep it consistent and rename it for all BlockHeader versions. That is also what I've done when adding prev_ prefix: #9500
pugachAG
approved these changes
Oct 10, 2023
nikurt
pushed a commit
that referenced
this pull request
Oct 11, 2023
Specify that gas price stored in block header is the price for chunks in the **next block**. It should improve readability of block production and verification, and emphasize that for post-state-root gas price computation is not impacted. ## Testing Not required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify that gas price stored in block header is the price for chunks in the next block. It should improve readability of block production and verification, and emphasize that for post-state-root gas price computation is not impacted.
Testing
Not required.