[resharding] Remove unit tests in favor of integration tests #9597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wacban
approved these changes
Oct 2, 2023
nikurt
pushed a commit
that referenced
this pull request
Oct 3, 2023
After trying out a couple of things to try to get the unit tests working with snapshotting for our resharding module, I feel like the complexity of resharding functions has reached a place where it might be fine to just remove the unit test module in favor of the integration tests. We have more flexibility with the integration tests and for now, the unit test and the integration tests are basically doing the same thing, The effort to make the unit test work with snapshot is probably not worth it.
nikurt
pushed a commit
that referenced
this pull request
Oct 11, 2023
After trying out a couple of things to try to get the unit tests working with snapshotting for our resharding module, I feel like the complexity of resharding functions has reached a place where it might be fine to just remove the unit test module in favor of the integration tests. We have more flexibility with the integration tests and for now, the unit test and the integration tests are basically doing the same thing, The effort to make the unit test work with snapshot is probably not worth it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After trying out a couple of things to try to get the unit tests working with snapshotting for our resharding module, I feel like the complexity of resharding functions has reached a place where it might be fine to just remove the unit test module in favor of the integration tests.
We have more flexibility with the integration tests and for now, the unit test and the integration tests are basically doing the same thing, The effort to make the unit test work with snapshot is probably not worth it.