8000 feat: introduce post-state-root protocol feature by pugachAG · Pull Request #9538 · near/nearcore · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: introduce post-state-root protocol feature #9538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 20, 2023
Merged

feat: introduce post-state-root protocol feature #9538

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3577277
impl
pugachAG Sep 19, 2023
63c3a58
Merge branch 'master' into post-state-root-protocol-feature
pugachAG Sep 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions core/primitives-core/src/version.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,9 @@ pub enum ProtocolFeature {
RejectBlocksWithOutdatedProtocolVersions,
#[cfg(feature = "protocol_feature_simple_nightshade_v2")]
SimpleNightshadeV2,
/// Enables block production with post-state-root.
/// NEP: https://github.com/near/NEPs/pull/507
PostStateRoot,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure rustc will complain about unused enum variants. Either mark it as an exception, or maybe just wait with introducing it until you have your first PR that actually needs it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like rustc is OK with it 🤷

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh right because it's pub it may be used outside the crate! Well, then I'm even more confused why we bother with hiding even the enum variants behind compilation flags, seems completely pointless to me. 🤔

}

impl ProtocolFeature {
Expand Down Expand Up @@ -173,6 +176,7 @@ impl ProtocolFeature {
ProtocolFeature::RejectBlocksWithOutdatedProtocolVersions => 132,
#[cfg(feature = "protocol_feature_simple_nightshade_v2")]
ProtocolFeature::SimpleNightshadeV2 => 135,
ProtocolFeature::PostStateRoot => 136,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the nightly protocol version is 138.

I guess it is fine to re-use protocol version numbers of stabilized features.

}
}
}
Expand Down
0