8000 [Epoch Sync] Implement EpochSyncProof validation · Issue #11932 · near/nearcore · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[Epoch Sync] Implement EpochSyncProof validation #11932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
robin-near opened this issue Aug 13, 2024 · 0 comments · Fixed by #12287
Closed

[Epoch Sync] Implement EpochSyncProof validation #11932

robin-near opened this issue Aug 13, 2024 · 0 comments · Fixed by #12287
Assignees
@staffik

Comments

@robin-near
Copy link
Contributor
robin-near commented Aug 13, 2024 •
edited
Loading

Need to make sure that every field of the EpochSync is validated against something.
@robin-near robin-near mentioned this issue Aug 13, 2024
Closed
@staffik staffik self-assigned this Aug 27, 2024
@staffik staffik mentioned this issue Aug 29, 2024
Merged
@github-actions github-actions bot mentioned this issue Sep 1, 2024
Closed
github-merge-queue bot pushed a commit that referenced this issue Oct 18, 2024
@staffik
[Epoch Sync] EpochSyncProof validation (#12020)
2c40e53 
Issue: #11932

Implements EpochSyncProof validation, according to:
- [design
doc](https://docs.google.com/document/d/14Itc9Hs7ewTRmcGANid9UCaYcJzaLzzM7FsvYYIFKDY/edit#heading=h.p2oiicluwd6o)
-
[`epoch_sync.rs`](https://github.com/near/nearcore/blob/d6d6e4782f7d57a7b7acc2894e1668355012ff74/core/primitives/src/epoch_sync.rs)

Summary:
- Move block merkle proof retrieval logic from `Chain` to a separate
trait (`MerkleProofAccess`). Make `Store` implements this trait so that
we can `get_block_proof` while serving `EpochSyncRequest` from a
separate thread and having no access to `Chain`.
- Refactor `verify_approval` and `compute_bp_hash` so that we can use it
for proof validation.
- Derive `first_block_info_in_epoch` from block header.
- Implement the validation logic.
- Add 2 more fields to the proof
  - `EpochSyncProofPastEpochData::protocol_version`
- `merkle_proof_for_first_block` generated at height of final block of
current epoch.
- Apparently, we need to add even more to enable generating
`merkle_proof_for_first_block` at the bootstrapped node. That will be
done as a foll
6E41
ow-up issue:
#12255.
- Create a bunch of follow-up issues (added to the [tracking
issue](near/near-one-project-tracking#73)):
  - #12255
  - #12256
  - #12258
  - #12259
  - #12260
@staffik staffik closed this as completed Oct 18, 2024
@robin-near robin-near linked a pull request Oct 23, 2024 that will close this issue
[Epoch Sync] Fix some epoch sync proof verification problems. #12287
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@staffik staffik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Epoch Sync] Fix some epoch sync proof verification problems. robin-near/nearcore
2 participants
@staffik @robin-near
0