-
Notifications
You must be signed in to change notification settings - Fork 71
Refactor the project and add generics and getter options #213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
e8093da
chore: Add ESLint and Prettier
petarvujovic98 cedd904
chore: Update ESLint configuration
petarvujovic98 e2639a7
feat: Update utils
petarvujovic98 95fb5ad
feat: Refactor collections
petarvujovic98 b769d5f
feat: Refactor high level promises
petarvujovic98 962335b
feat: Refactor API internally
petarvujovic98 dba601b
feat: Refactor build tools
petarvujovic98 0a9c285
feat: Refactor CLI tools
petarvujovic98 16b3f4d
chore: Fix formatting
petarvujovic98 1f2af4b
fix: Fix parameter types
petarvujovic98 bfde857
fix: Add build for API refactor
petarvujovic98 ca1d1d4
chore: Add linting job to CI
petarvujovic98 58f0966
chore: Add formatting checks to Lint workflow
petarvujovic98 e0c4ceb
fix: Fix linting errors and ESLint config
petarvujovic98 89678ea
chore: Fix linting and formatting
petarvujovic98 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,46 @@ | ||
module.exports = { | ||
root: true, | ||
env: { | ||
es2021: true, | ||
node: true, | ||
}, | ||
overrides: [ | ||
{ | ||
files: ["./**/*.ts", "./**/*.js"], | ||
extends: [ | ||
"eslint:recommended", | ||
"plugin:@typescript-eslint/recommended", | ||
"prettier", | ||
], | ||
parser: "@typescript-eslint/parser", | ||
parserOptions: { | ||
ecmaVersion: "latest", | ||
sourceType: "module", | ||
project: ["./{t,j}sconfig.json", "./**/{t,j}sconfig.json"], | ||
}, | ||
plugins: ["@typescript-eslint"], | ||
rules: { | ||
"@typescript-eslint/no-unused-vars": [ | ||
"warn", | ||
{ | ||
varsIgnorePattern: "^_", | ||
argsIgnorePattern: "^_", | ||
destructuredArrayIgnorePattern: "^_", | ||
caughtErrorsIgnorePattern: "^_", | ||
}, | ||
], | ||
}, | ||
}, | ||
], | ||
ignorePatterns: [ | ||
"./**/node_modules", | ||
"node_modules", | ||
"./**/lib", | ||
"lib", | ||
"./**/build", | ||
"build", | ||
"./**/deps", | ||
"deps", | ||
], | ||
rules: {}, | ||
}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
name: Build | ||
on: | ||
on: | ||
pull_request: | ||
push: | ||
branches: | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
name: Lint | ||
on: | ||
pull_request: | ||
push: | ||
branches: | ||
- master | ||
- develop | ||
jobs: | ||
lint: | ||
strategy: | ||
matrix: | ||
platform: [ubuntu-latest] | ||
runs-on: ${{ matrix.platform }} | ||
steps: | ||
- name: Checkout code | ||
uses: actions/checkout@v2 | ||
- name: Setup Node.js | ||
uses: actions/setup-node@v2 | ||
with: | ||
node-version: "16" | ||
- name: Install modules | ||
run: yarn | ||
- name: Run lint | ||
run: yarn lint | ||
- name: Format code | ||
run: yarn format | ||
- name: Run git status | ||
run: git status | ||
- name: Check that lints where commited | ||
run: test -z "$(git status --porcelain)" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
name: Unit tests | ||
on: | ||
on: | ||
pull_request: | ||
push: | ||
branches: | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
deps | ||
build | ||
node_modules | ||
lib | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The underlying engine quickjs only support es2020: https://bellard.org/quickjs/ so we need es2020 here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ailisp This is just for the code we are writing, doesn't have to do anything with the target for the TypeScript compilation. So we are using newer features in code, or at least we could be, but then the TypeScript compiler will build them to whatever version we choose in the
tsconfig.json
file.