8000 Fix seed phrase so it works with masterAccount by mehtaphysical · Pull Request #739 · near/near-cli · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Oct 4, 2024. It is now read-only.

Fix seed phrase so it works with masterAccount #739

Merged
merged 6 commits into from 8000
May 11, 2021
Merged

Fix seed phrase so it works with masterAccount #739

merged 6 commits into from
May 11, 2021

Conversation

mehtaphysical
Copy link
Contributor

Fixes #696

Checks if a masterAccount is passed as an arg. If so, applies the seed phrase to the masterAccount instead of accountId. Merges the InMemoryKeyStore created with the seed phrase into the MeregKeyStore.

@mehtaphysical mehtaphysical mentioned this pull request May 6, 2021
Closed
@volovyks
Copy link
Collaborator
volovyks commented May 7, 2021

@mehtaphysical looks good overall
let's create a simple test in test_account_creation.sh that will cover the flow described by Alex.

Also, not sure if it's on master or on this branch, but we should not have 2k+ changes in yarn.lock :)

@mehtaphysical
Copy link
Contributor Author

Yeah I think its because web3 and a few other libraries where removed from master, but the yarn.lock wasn't updated.

@mehtaphysical
Copy link
Contributor Author

Sorry I made this PR sort of big. I can split this if that's better.

The tests where hard to read, so I made the test printing less verbose and added a bottom section with a summary:

Screenshot from 2021-05-07 08-40-25

@thisisjoshford
Copy link
Contributor
thisisjoshford commented May 10, 2021 •
edited
Loading

Yeah I think its because web3 and a few other libraries where removed from master, but the yarn.lock wasn't updated.

@mehtaphysical I did remove web3 and a few libraries but the yarn.lock should have been updated see here

@volovyks
Copy link
Collaborator

@mehtaphysical wow, status for each .sh is very helpful!
Let's make CI green here and merge it then!

@mehtaphysical
Copy link
Contributor Author

@volovyk-s @thisisjoshford tests passing now :)

@mikedotexe
Copy link
Contributor

Shoot, we have conflicts now @mehtaphysical

@mehtaphysical mehtaphysical merged commit 6222bbd into master May 11, 2021
@mehtaphysical mehtaphysical deleted the fix/seed-phrase-create-account branch May 11, 2021 01:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mikedotexe mikedotexe mikedotexe approved these changes

@volovyks volovyks volovyks approved these changes

@thisisjoshford thisisjoshford thisisjoshford approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot submit a create-account transaction using --seedPhrase
4 participants
@mehtaphysical @volovyks @thisisjoshford @mikedotexe
0