8000 remove evm commands by thisisjoshford · Pull Request #734 · near/near-cli · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Oct 4, 2024. It is now read-only.

remove evm commands #734

Merged
merged 9 commits into from
May 5, 2021
Merged

remove evm commands #734

merged 9 commits into from
May 5, 2021

Conversation

thisisjoshford
Copy link
Contributor
@thisisjoshford thisisjoshford commented May 4, 2021 •
edited
Loading

fixes #706
fixes #675

mehtaphysical
mehtaphysical suggested changes May 4, 2021
View reviewed changes
Copy link
Contributor
@mehtaphysical mehtaphysical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should keep the commands and either:

  • fail and print a message to use the aurora cli
  • print a deprecation warning with a message to use the aurora cli

mehtaphysical
mehtaphysical reviewed May 4, 2021
View reviewed changes
Copy link
Contributor
@mehtaphysical mehtaphysical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, can probably remove the web3 and near-web3-provider with this PR also

mehtaphysical
mehtaphysical approved these changes May 5, 2021
View reviewed changes
Copy link
Contributor
@mehtaphysical mehtaphysical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Seems like the tests are failing because there was a problem with the RPC server. Rerun the tests to make sure.

@thisisjoshford thisisjoshford merged commit 160b654 into master May 5, 2021
@thisisjoshford thisisjoshford deleted the fix/remove-evm-commands branch May 5, 2021 15:38
@mikedotexe mikedotexe mentioned this pull request May 6, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mehtaphysical mehtaphysical mehtaphysical approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove EVM commands remove dependence on web3.js
2 participants
@thisisjoshford @mehtaphysical
0