This repository was archived by the owner on Oct 4, 2024. It is now read-only.
deprecate default folder #709
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
need to fix CI tests |
mikedotexe
reviewed
Apr 8, 2021
|
Yeah looks like |
mikedotexe
approved these changes
Apr 14, 2021
mehtaphysical
approved these changes
Apr 15, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there are two directories for
testnetcredentials.defaulttestnetThis can be confusing as
create-near-appand other example apps store access keys intestnetwhilenear-clistores access keys indefault. Users report running into errors when trying to runnear-clicommands with credentials in the wrong location. (see linked issue below)This PR deprecates the
defaultdirectory changing it totestnetand prompts users of this change. It also checks thedefaultdirectory for the credentials (if not found intestnet) and asks users if they would like us to copy their keys to the new location. This leaves two copies of an account's access keys to avoid breaking changes until we decide to permanently removedefault.Fixes #677