8000 426 consistent scoring rules by nicholasloveday · Pull Request #540 · nci/scores · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

426 consistent scoring rules #540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 55 commits into from 8000
Jun 26, 2024
Merged

426 consistent scoring rules #540

merged 55 commits into from
Jun 26, 2024

Conversation

nicholasloveday
Copy link
Collaborator
@nicholasloveday nicholasloveday commented Jun 14, 2024 •
edited
Loading

Development for new xarray-based metrics

  • Works with n-dimensional data and includes reduce_dims, preserve_dims, and weights args.
  • Typehints added
  • Docstrings complete and followed Napoleon (google) style
  • Reference to paper/webpage is in docstring
  • Add error handling
  • Imported into the API

Testing of new xarray-based metrics

  • 100% unit test coverage
  • Test that metric is compatible with dask.
  • Test that metrics work with inputs that contain NaNs
  • Test that broadcasting with xarray works
  • Test both reduce and preserve dims arguments work
  • Test that errors are raised as expected

Tutorial notebook

  • Short introduction to why you would use that metric and what it tells you
  • A link to a reference
  • A "things to try next" section at the end
  • Add notebook to Tutorial_Gallery.ipynb
  • Optional - a detailed discussion of how the metric works at the end of the notebook

Documentation

tennlee
tennlee reviewed Jun 14, 2024
View reviewed changes
@nicholasloveday nicholasloveday changed the title (in development) 426 consistent scoring rules (ready for review) 426 consistent scoring rules Jun 14, 2024
@nicholasloveday nicholasloveday changed the title (ready for review) 426 consistent scoring rules (in development) 426 consistent scoring rules Jun 14, 2024
@nicholasloveday nicholasloveday changed the title (in development) 426 consistent scoring rules (ready for review) 426 consistent scoring rules Jun 14, 2024
@nicholasloveday

This comment was marked as resolved.

Sign in to view
Steph-Chong
Steph-Chong reviewed Jun 14, 2024
View reviewed changes
Steph-Chong
Steph-Chong reviewed Jun 14, 2024
View reviewed changes
Steph-Chong

This comment was marked as resolved.

Sign in to view

@nicholasloveday nicholasloveday linked an issue Jun 14, 2024 that may be closed by this pull request
Consistent scoring rules #426
Closed
Steph-Chong
Steph-Chong reviewed Jun 14, 2024
View reviewed changes
@tennlee

This comment was marked as resolved.

Sign in to view
@nicholasloveday

This comment was marked as resolved.

Sign in to view
@nicholasloveday nicholasloveday force-pushed the 426-consistent-scoring-rules branch 2 times, most recently from 5e79740 to ff75cfc Compare June 17, 2024 00:36
@nicholasloveday nicholasloveday force-pushed the 426-consistent-scoring-rules branch from 7c7cc79 to 2be8d4f Compare June 26, 2024 02:52
@nicholasloveday

This comment was marked as resolved.

Sign in to view
@Steph-Chong

This comment was marked as resolved.

Sign in to view
@nicholasloveday nicholasloveday force-pushed the 426-consistent-scoring-rules branch from 254d72b to dfd56c4 Compare June 26, 2024 03:11
@Steph-Chong

This comment was marked as resolved.

Sign in to view
@nicholasloveday

This comment was marked as resolved.

Sign in to view
@nicholasloveday

This comment was marked as resolved.

Sign in to view
@Steph-Chong

This comment was marked as resolved.

Sign in to view
@nicholasloveday

This comment was marked as resolved.

Sign in to view
@Steph-Chong

This comment was marked as resolved.

Sign in to view
@nicholasloveday

This comment was marked as resolved.

Sign in to view
@Steph-Chong

This comment was marked as resolved.

Sign in to view
@nicholasloveday

This comment was marked as resolved.

Sign in to view
@Steph-Chong

This comment was marked as resolved.

Sign in to view
Steph-Chong
Steph-Chong reviewed Jun 26, 2024
View reviewed changes
@nicholasloveday @Steph-Chong
Apply suggestions from code review
21f4181 
Co-authored-by: Stephanie Chong <168800785+Steph-Chong@users.noreply.github.com>
Signed-off-by: Nicholas Loveday <48701367+nicholasloveday@users.noreply.github.com>
Steph-Chong
Steph-Chong reviewed Jun 26, 2024
View reviewed changes
nicholasloveday and others added 3 commits June 26, 2024 15:42
@nicholasloveday @Steph-Chong
Apply suggestions from code review
4636ae4 
Co-authored-by: Stephanie Chong <168800785+Steph-Chong@users.noreply.github.com>
Signed-off-by: Nicholas Loveday <48701367+nicholasloveday@users.noreply.github.com>
@nicholasloveday
add page numbers to ref
707feea
@nicholasloveday
added a to ref
0 6D40 739b36
@tennlee tennlee merged commit ed1a2be into nci:develop Jun 26, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rob-taggart rob-taggart rob-taggart left review comments

@tennlee tennlee tennlee left review comments

@Steph-Chong Steph-Chong Steph-Chong left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consistent scoring rules
4 participants
@nicholasloveday @tennlee @Steph-Chong @rob-taggart
0