Test the Heidke Skill Score and Gilbert Skill Score against a known complex example #502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tennlee
commented
Jun 10, 2024
| # Note - the reference in the CAWCR verification site has 0.36 for | ||
| # the expected result, but presumably this is rounded to two decimal | ||
| # places | ||
| expected = xr.DataArray(0.355325) |
There was a problem hiding this comment.
@nicholasloveday, please check this result is expected given the CAWCR site lists 0.36.
|
I have taken the same approach for the Gilbert Skill Score (Equitable Threat Score) and put the test into this PR. As such, this may also resolve #334. @nicholasloveday I'll leave you to review both and approve both. |
nicholasloveday
approved these changes
Jun 12, 2024
| # Note - the reference in the verification site has 0.22 for the expected | ||
| # result, but presumably this is rounded to two decimal places | ||
| # See https://www.cawcr.gov.au/projects/verification/Finley/Finley_Tornados.html | ||
| gilbert_expected = xr.DataArray(0.216046) |
| # Note - the reference in the verification site has 0.36 for the expected | ||
| # result, but presumably this is rounded to two decimal places | ||
| # See https://www.cawcr.gov.au/projects/verification/Finley/Finley_Tornados.html | ||
| heidke_expected = xr.DataArray(0.355325) |
This was referenced Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
May resolve #337
@nicholasloveday I have added the test you suggested from the CAWCR site and compared the results.