feat(server): custom ArtistJoiner config #3873
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Deluan <deluan@navidrome.org>
Signed-off-by: Deluan <deluan@navidrome.org>
Signed-off-by: Deluan <deluan@navidrome.org>
mintsoft
pushed a commit
to mintsoft/navidrome
that referenced
this pull request
Mar 23, 2025
* feat(server): custom ArtistJoiner config Signed-off-by: Deluan <deluan@navidrome.org> * refactor(ui): organize ArtistLinkField, add tests Signed-off-by: Deluan <deluan@navidrome.org> * feat(ui): use display artist * feat(ui): use display artist Signed-off-by: Deluan <deluan@navidrome.org> --------- Signed-off-by: Deluan <deluan@navidrome.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces changes to enhance the handling of artist and remixer metadata, improve the configuration options, and add comprehensive testing for the
ArtistLinkFieldcomponent. The most important changes include adding a new configuration option for the artist joiner, updating the metadata mapping to use this new configuration, and refactoring theArtistLinkFieldcomponent to handle artists and remixers more effectively.Configuration Enhancements:
conf/configuration.go: Added a new configuration optionScanner.ArtistJoiner, default value is" • ".Metadata Mapping Updates:
model/metadata/map_participants.go: Updated themapDisplayNamefunction to use the newArtistJoinerconfiguration fromconf.Server.Scanner.UI Component Refactoring:
ui/src/common/ArtistLinkField.jsx: Refactored theArtistLinkFieldcomponent to improve handling of artists and remixers, including deduplication and limiting the number of remixers displayed. [1] [2]Testing Enhancements:
ui/src/common/ArtistLinkField.test.jsx: Added comprehensive tests for theArtistLinkFieldcomponent to cover various scenarios, including rendering artists, handling remixers, deduplication, and limiting displayed artists.