8000 fix(insights): improving reports by deluan · Pull Request #3558 · navidrome/navidrome · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(insights): improving reports #3558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into master from
Dec 19, 2024
Merged

fix(insights): improving reports #3558

merged 8 commits into from
Dec 19, 2024

Conversation

deluan
Copy link
Member
@deluan deluan commented Dec 18, 2024 •
edited
Loading
  • Add logs when there are errors getting library counters
  • Fix vcs.modified=true when there are no changes
  • Wait 30 minutes before first report, to avoid 429s from the insights server on restart
  • Disable reports when running in dev mode (make server or make dev)
  • Report clients counters (number of API clients, grouped by client type)
  • Add more FS types (ex: FUSE)

@deluan
fix(insights): show error whn reading library counts
aa9a389 
Signed-off-by: Deluan <deluan@navidrome.org>
@github-actions GitHub Actions
Copy link
github-actions bot commented Dec 18, 2024 •
edited
Loading
8000

Download the artifacts for this pull request:

@deluan
fix(insights): wait 30 mins before send first report
2cc79f3 
Signed-off-by: Deluan <deluan@navidrome.org>
@deluan
fix(insights): send number of active players, grouped by client type
ee7a3dc 
Signed-off-by: Deluan <deluan@navidrome.org>
@deluan
fix(insights): disable reports when running in dev mode
f2f996b 
Signed-off-by: Deluan <deluan@navidrome.org>
@deluan
fix(insights): add Dockerfile to the docker build, to avoid `vcs.modi…
39b243d 
…fied=true`

Signed-off-by: Deluan <deluan@navidrome.org>
@deluan deluan changed the title fix(insights): log any errors when reading library counts fix(insights): improving reports Dec 18, 2024
@deluan
fix(insights): add more linux fs types
f91 8000 2e55 
Signed-off-by: Deluan <deluan@navidrome.org>
@deluan
fix(insights): need admin permissions to retrieve library counts
f5e3b4e 
Signed-off-by: Deluan <deluan@navidrome.org>
@deluan
fix(insights): dev flag to disable player insights
14b24f8 
Signed-off-by: Deluan <deluan@navidrome.org>
@deluan deluan merged commit 6c11649 into master Dec 19, 2024
34 checks passed
@deluan deluan deleted the fix-insights branch December 19, 2024 01:37
@github-actions GitHub Actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
frozen-due-to-age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@deluan
0