Server utility script cleanup #373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit 490bc8a and detected 1 issue on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
|
Taking this back to draft actually because now is as good a time as any to turn these into |
This script was barely functional, barely useful, and likely to remain neglected. Use existing tools to perform elastic snapshots and/or backups isntead.
This closes #216 and as an extra, adds a couple new commands to the command line utilities.
ajacques
approved these changes
Aug 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No associated issues for this, but useful and standalone updates nonetheless.
Removes the legacy
elastic-snapshot.pyutility, which was barely functional at best, and actively misleading at worst. I have no intention of supporting elastic snapshotting as part of the application, which requires configuring the elastic cluster and then using that information in the application. There are surely other tools that handle setting up point-in-time or periodic elastic snapshots much better than this script ever did.Updates
add-user.pyandadd-scope.pyto be more proactive about ensuring necessary arguments are provided and don't require an entire (time-costly) app construction just to look at the arguments.add-user.pyno longer modifies existing users, which was, in my opinion, a confusing behavior for a tool namedadd-user.add-scope.pynow produces json output instead of the simple prints that it used to use. The json output makes more sense to redirect to a file, too. E.g.docker exec -ti natlas-server ./add-scope.py --blacklist /data/test_scope.txt --verbose > test_import.jsonThe remaining concern I have with the
add-scopeutility is that it only reads from files which means docker cp will still be necessary to gettest_scope.txtinto the context of the container (though we should generally always be mounting a persistent directory to/dataso maybe that isn't as big a deal).