feat(sentry)(agent): Improve how exceptions are handled for Sentry in the agent #445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit b5fe1ca and detected 0 issues on this pull request. View more on Code Climate. |
ajacques
commented
Aug 20, 2020
0xdade
approved these changes
Aug 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The natlas agent seems to always report using log statements instead of real errors. I hate the logs because they lose context and aren't multi-threaded correctly, so I did some work to improve how Sentry errors are reported. I'm not enabling tracing yet because Sentry's version is in early testing and I need more time to decide on OpenTelemetry vs Sentry.