Stop benchmark reporting if benchmark action is skipped #8037
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8037 +/- ##
==========================================
+ Coverage 93.01% 93.05% +0.04%
==========================================
Files 648 648
Lines 61463 61463
==========================================
+ Hits 57171 57196 +25
+ Misses 4292 4267 -25 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Czaki
approved these changes
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References and relevant issues
When I merge PRs, I get spammed in my notifications that benchmarks reporting has failed -- it looks like it only succeeds on the chron run lately. https://github.com/napari/napari/actions/workflows/benchmarks_report.yml
The problem is that
combine-artifactsalways runs, regardless of whether benchmarks is skipped. The action triggers on PR merge, but is skipped unless thebenchmarkslabel is added.Description
combine-artifactsonly runs if benchmarks is not skipped.Thus, the benchmark report action will stop triggering fails if benchmarks are skipped.
Alternative
Remove running the benchmark action on merging of benchmark labeled PRs, but this would be a regression. I'm guessing this functionality is there to double check affected PRs.