8000 Update docstring in `mouse_drag_callback.py` by rahul713rk · Pull Request #8019 · napari/napari · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update docstring in mouse_drag_callback.py #8019

8000
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 18, 2025
Merged

Conversation

rahul713rk
Copy link
Contributor

References and relevant issues

Closes #8016

Description

This PR updates the docstring/description in mouse_drag_callback.py to accurately describe the current behavior of the example.

  • Removed outdated reference to the status bar .
  • Clarified that line profile averages are printed to the terminal .

Copy link
codecov bot commented Jun 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.97%. Comparing base (81c9180) to head (449768c).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8019      +/-   ##
==========================================
+ Coverage   92.91%   92.97%   +0.05%     
==========================================
  Files         647      647              
  Lines       60915    60975      +60     
==========================================
+ Hits        56600    56689      +89     
+ Misses       4315     4286      -29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member
@psobolewskiPhD psobolewskiPhD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.

@psobolewskiPhD psobolewskiPhD added the example Adds or fixes a napari example (core or plugin) label Jun 14, 2025
@psobolewskiPhD psobolewskiPhD added this to the 0.6.2 milestone Jun 14, 2025
@psobolewskiPhD
Copy link
Member

Test fails are unrelated, affecting everything right now 😢

Comment on lines 5 to 6
Example printing line profile averages to the terminal while
dragging lines in a shapes layer over an image.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Example printing line profile averages to the terminal while
dragging lines in a shapes layer over an image.
This example shows how to use a mouse drag callback in napari to compute
and print the average intensity along a line Shape as it is moved over an Image layer.

I just saw your comment on the issue -- sorry! -- I like the extra detail you had in the 2nd option there.

Copy link
Contributor
8000

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this suggestion as well (or some variant that includes the more descriptive version from #8016 (comment))

Thank you!

@rahul713rk
Copy link
Contributor Author

I have implemented the suggested changes . Thank's for Feedback . Let me know, there is any changes.

@TimMonko TimMonko added ready to merge Last chance for comments! Will be merged in ~24h documentation Documentation content and tooling labels Jun 16, 2025
@TimMonko TimMonko merged commit a40cc87 into napari:main Jun 18, 2025
43 of 45 checks passed
@github-actions github-actions bot removed the ready to merge Last chance for comments! Will be merged in ~24h label Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation content and tooling example Adds or fixes a napari example (core or plugin)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the description of the mouse_drag_callback example
3 participants
0