8000 fix `ScalarField._get_value_3d` to return information about data level for multiscale by Czaki · Pull Request #7849 · napari/napari · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix ScalarField._get_value_3d to return information about data level for multiscale #7849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 23, 2025
Merged

fix ScalarField._get_value_3d to return information about data level for multiscale #7849

merged 3 commits into from
Apr 23, 2025

Conversation

Czaki
Copy link
Collaborator
@Czaki Czaki commented Apr 22, 2025 •
edited by jni
Loading

References and relevant issues

closes #7848

Description

Fix ScalarFieldBase._get_value_3d to properly handle multiscale 3d data consistently with multiscale 2d data, by including the level information in a tuple.

@Czaki Czaki added the bugfix PR with bugfix label Apr 22, 2025
@Czaki Czaki requested a review from psobolewskiPhD April 22, 2025 19:34
@Czaki Czaki requested a review from a team as a code owner April 22, 2025 19:34
@Czaki Czaki requested review from jni and brisvag as code owners April 22, 2025 22:54
@github-actions github-actions bot added the tests Something related to our tests label Apr 22, 2025
@codecov Codecov
Copy link
codecov bot commented Apr 22, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.95%. Comparing base (7fa8c78) to head (e9d677a).
Report is 8 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7849      +/-   ##
==========================================
- Coverage   92.98%   92.95%   -0.04%     
==========================================
  Files         635      635              
  Lines       59857    59860       +3     
==========================================
- Hits        55661    55645      -16     
- Misses       4196     4215      +19

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jni jni added this to the 0.6.0 milestone Apr 23, 2025
TimMonko
TimMonko approved these changes Apr 23, 2025
View reviewed changes
Copy link
Contributor
@TimMonko TimMonko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@jni jni added the ready to merge Last chance for comments! Will be merged in ~24h label Apr 23, 2025
@jni jni merged commit 95b1e66 into napari:main Apr 23, 2025
39 of 44 checks passed
@jni jni deleted the fix_getting_status_multiscale_3d branch April 23, 2025 09:03
@github-actions github-actions bot removed the ready to merge Last chance for comments! Will be merged in ~24h label Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jni jni jni approved these changes

@TimMonko TimMonko TimMonko approved these changes

@psobolewskiPhD psobolewskiPhD Awaiting requested review from psobolewskiPhD

@brisvag brisvag Awaiting requested review from brisvag brisvag is a code owner

Assignees
No one assigned
Labels
bugfix PR with bugfix tests Something related to our tests
Projects
None yet
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.

[Labels, multiscale] Index Error when mousing over labels with features in 3D
3 participants
@Czaki @jni @TimMonko
0