8000 Use proper token in update dependencies workflow by Czaki · Pull Request #7821 · napari/napari · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Use proper token in update dependencies workflow #7821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2025

Conversation

Czaki
Copy link
Collaborator
@Czaki Czaki commented Apr 14, 2025

References and relevant issues

Follow up to #7820.

Description

In #7820, we changed the dependencies update bot to make pull requests from its own fork, rather than by pushing to the main napari repo. However, the token used in that step had permissions for the main repo and not for the fork. This PR updates the token to use the one for commenting on the issue, which should have the correct permissions.

@Czaki Czaki requested a review from a team as a code owner April 14, 2025 14:27
@github-actions github-actions bot added the maintenance PR with maintance changes, label Apr 14, 2025
@Czaki Czaki added this to the 0.6.0 milestone Apr 14, 2025
@jni jni added the ready to merge Last chance for comments! Will be merged in ~24h label Apr 14, 2025
Copy link
codecov bot commented Apr 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.94%. Comparing base (124bdca) to head (029e141).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7821      +/-   ##
==========================================
- Coverage   92.97%   92.94%   -0.03%     
==========================================
  Files         634      634              
  Lines       59453    59453              
==========================================
- Hits        55274    55257      -17     
- Misses       4179     4196      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Czaki Czaki merged commit f487152 into napari:main Apr 14, 2025
47 checks passed
@Czaki Czaki deleted the constraints_docs_from_bot_repo2 branch April 14, 2025 15:19
@github-actions github-actions bot removed the ready to merge Last chance for comments! Will be merged in ~24h label Apr 14, 2025
Czaki added a commit that referenced this pull request Apr 14, 2025
… name collisions, that prevents push (#7822)

# References and relevant issues

Follow up to #7821

# Description

Today I learned that if you have branch `branch/something` you cannot
have branch `branch`

```
stderr: To https://github.com/napari-bot/napari.git
 ! [remote rejected] auto-update-dependencies -> auto-update-dependencies (cannot lock ref 'refs/heads/auto-update-dependencies': 'refs/heads/auto-update-dependencies/Carreau/napari/qtpy6-mypy' exists; cannot create 'refs/heads/auto-update-dependencies')
error: failed to push some refs to 'https://github.com/napari-bot/napari.git'
```

So this PR add suffix `-main` to distinguish it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance PR with maintance changes,
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0