Add scale bar box toggle to view > scale bar menu #7815
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jni could be worth getting this into 0.6.0 given the command palette and box fixes are going live there. But it's fine if it slips to 0.6.1 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7815 +/- ##
==========================================
- Coverage 92.98% 92.95% -0.03%
==========================================
Files 634 634
Lines 59445 59445
==========================================
- Hits 55277 55260 -17
- Misses 4168 4185 +17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jni
approved these changes
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References and relevant issues
Closes: #6991
Description
This PR adds an action to toggle the scale bar box to the View menu.
This improves discoverability and enables the use of this from the command palette.
Given that the functionality was fixed in #7750 it seems worth it to better expose now, especially with the command palette.