Prevent from triggering notification animation in tests #7802
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Czaki
commented
Apr 8, 2025
Comment on lines
+499
to
+500
| or ConfirmCloseDialog(self, quit_app).exec_() | ||
| == QDialog.DialogCode.Accepted |
There was a problem hiding this comment.
It is not related to the main topic of PR, but I put it here to not create single line PR.
Just proper Enum usage.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7802 +/- ##
==========================================
- Coverage 92.98% 92.93% -0.06%
==========================================
Files 633 633
Lines 59431 59433 +2
==========================================
- Hits 55263 55233 -30
- Misses 4168 4200 +32 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
TimMonko
approved these changes
Apr 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References and relevant issues
extracted from #7780
Description
Do not start
slide_inanimation for notification in tests.Prevent from creating a notification dialog if the current main window is hidden.