Postpone QtViewer deprecation to 0.7.0 #7791
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7791 +/- ##
==========================================
- Coverage 92.99% 92.95% -0.04%
==========================================
Files 633 633
Lines 59444 59444
==========================================
- Hits 55277 55254 -23
- Misses 4167 4190 +23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Czaki
approved these changes
Apr 7, 2025
psobolewskiPhD
approved these changes
Apr 7, 2025
|
Should just mark it 1.0.0 😉 |
TimMonko
approved these changes
Apr 7, 2025
Normally, I'd agree but I'm getting started with #7778, so maybe we'll get there. All I need is a little payment as motivation, perhaps 1 heart per PR ❤️ |
willingc
approved these changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #7701. We haven't created the necessary models to complete this
deprecation (for example, a way to query canvas size or coordinate
limits), so we have to postpone it.