8000 Remove deprecated Interpolation attribute from Image layer by willingc · Pull Request #7741 · napari/napari · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove deprecated Interpolation attribute from Image layer #7741

8000
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 25, 2025
Merged

Remove deprecated Interpolation attribute from Image layer #7741

merged 3 commits into from
Mar 25, 2025

Conversation

willingc
Copy link
Collaborator

References and relevant issues

Partially addresses #7550 Replaces #7731

Description

Removes interpolation attribute which was replaced by interpolation 2d and interpolation 3d attributes in the image layer.

@github-actions github-actions bot added the tests Something related to our tests label Mar 24, 2025
@willingc willingc added this to the 0.6.0 milestone Mar 24, 2025
@willingc willingc requested a review from melonora as a code owner March 24, 2025 06:56
@codecov Codecov
Copy link
codecov bot commented Mar 24, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.86%. Comparing base (56f4ff9) to head (0754a51).
Report is 5 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7741      +/-   ##
==========================================
+ Coverage   92.73%   92.86%   +0.12%     
==========================================
  Files         633      633              
  Lines       59408    59373      -35     
==========================================
+ Hits        55092    55135      +43     
+ Misses       4316     4238      -78

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jni jni added maintenance PR with maintance changes, ready to merge Last chance for comments! Will be merged in ~24h labels Mar 24, 2025
@jni jni merged commit c043e53 into napari:main Mar 25, 2025
44 checks passed
@github-actions github-actions bot removed the ready to merge Last chance for comments! Will be merged in ~24h label Mar 25, 2025
jni added a commit to jni/napari that referenced this pull request Apr 7, 2025
@jni
Remove deprecated interpolation argument from add_image
1b3ac8e 
ViewerModel.add_image is specially defined and doesn't rely on the
Image layer constructor, which is why it was not caught in napari#7741.
This completes the removal of the argument by removing it from
add_image.
@jni jni mentioned this pull request Apr 7, 2025
Merged
jni added a commit that referenced this pull request Apr 8, 2025
@jni @Czaki
Remove deprecated interpolation argument from add_image (#7793)
e13cfe4 
Part of #7701

ViewerModel.add_image is specially defined and doesn't rely on the
Image layer constructor, which is why it was not caught in #7741.
This completes the removal of the argument by removing it from
add_image.

---------

Co-authored-by: Grzegorz Bokota <bokota+github@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jni jni jni approved these changes

@Czaki Czaki Awaiting requested review from Czaki Czaki is a code owner

@brisvag brisvag Awaiting requested 6D79 review from brisvag brisvag is a code owner

@kephale kephale Awaiting requested review from kephale kephale is a code owner

@melonora melonora Awaiting requested review from melonora melonora is a code owner

Assignees
No one assigned
Labels
maintenance PR with maintance changes, tests Something related to our tests
Projects
None yet
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@willingc @jni
0