8000 Remove deprecated camera.interactive by willingc · Pull Request #7733 · napari/napari · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove deprecated camera.interactive #7733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 24, 2025
Merged

Remove deprecated camera.interactive #7733

merged 4 commits into from
Mar 24, 2025

Conversation

willingc
Copy link
Collaborator
@willingc willingc commented Mar 21, 2025 •
edited
Loading

References and relevant issues

Partially addresses #7550. Replaces #7731 which is being split up.

Original PR that set the deprecation: #5701

Description

  • Remove deprecated camera.interactive.

@willingc willingc requested a review from a team as a code owner March 21, 2025 19:35
@willingc willingc force-pushed the camera-interactive branch from 74f9271 to 856543e Compare March 21, 2025 19:51
@codecov Codecov
Copy link
codecov bot commented Mar 21, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.86%. Comparing base (c6bf619) to head (3c81a04).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7733      +/-   ##
==========================================
- Coverage   92.87%   92.86%   -0.02%     
==========================================
  Files         633      633              
  Lines       59435    59411      -24     
==========================================
- Hits        55201    55171      -30     
- Misses       4234     4240       +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions github-actions bot added the tests Something related to our tests label Mar 21, 2025
@willingc willingc changed the title Remove deprecated camera.interactive Remove deprecated camera.interactive and related mouse_pan and mouse_zoom Mar 22, 2025
@willingc
Copy link
Collaborator Author
willingc commented Mar 22, 2025 •
edited
Loading

@jni unsure if mouse_pan and mouse_zoom bool should be removed.

I left any mouse_pan and mouse_zoom code in tact within the _vispy folder.

Update: Thanks to Peter for helping with context and I found the original deprecation PR.

@psobolewskiPhD
Copy link
Member

Drive-by from phone, but pretty sure mouse_pan and mouse_zoom replaced interactive, so we need to keep em.

@willingc willingc force-pushed the camera-interactive branch from 00fba34 to b5979f7 Compare March 22, 2025 00:26
@willingc willingc changed the title Remove deprecated camera.interactive and related mouse_pan and mouse_zoom Remove deprecated camera.interactive Mar 22, 2025
@willingc willingc added this to the 0.6.0 milestone Mar 22, 2025
@psobolewskiPhD psobolewskiPhD added the maintenance PR with maintance changes, label Mar 22, 2025
psobolewskiPhD
psobolewskiPhD reviewed Mar 22, 2025
View reviewed changes
psobolewskiPhD
psobolewskiPhD reviewed Mar 22, 2025
View reviewed changes
willingc and others added 2 commits March 22, 2025 14:24
@willingc @psobolewskiPhD
Update napari/components/camera.py
a6ddb9e 
Co-authored-by: Peter Sobolewski <76622105+psobolewskiPhD@users.noreply.github.com>
@willingc @psobolewskiPhD
Update napari/components/camera.py
3c81a04 
Co-authored-by: Peter Sobolewski <76622105+psobolewskiPhD@users.noreply.github.com>
@jni jni added the ready to merge Last chance for comments! Will be merged in ~24h label Mar 24, 2025
@jni jni merged commit fd1aa5e into napari:main Mar 24, 2025
40 checks passed
@github-actions github-actions bot removed the ready to merge Last chance for comments! Will be merged in ~24h label Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psobolewskiPhD psobolewskiPhD psobolewskiPhD left review comments

@jni jni jni approved these changes

@kevinyamauchi kevinyamauchi Awaiting requested review from kevinyamauchi

@DragaDoncila DragaDoncila Awaiting requested review from DragaDoncila

@melonora melonora Awaiting requested review from melonora

@brisvag brisvag Awaiting requested review from brisvag

@kephale kephale Awaiting requested review from kephale

@Czaki Czaki Awaiting requested review from Czaki

@melissawm melissawm Awaiting requested review from melissawm

@lucyleeow lucyleeow Awaiting requested review from lucyleeow

Assignees
No one assigned
Labels
maintenance PR with maintance changes, tests Something related to our tests
Projects
None yet
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@willingc @psobolewskiPhD @jni
0