8000 [CI] skip flaky camera_3d test on windows by psobolewskiPhD · Pull Request #7709 · napari/napari · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[CI] skip flaky camera_3d test on windows #7709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 17, 2025
Merged

[CI] skip flaky camera_3d test on windows #7709

merged 4 commits into from
Mar 17, 2025

Conversation

psobolewskiPhD
Copy link
Member
@psobolewskiPhD psobolewskiPhD commented Mar 16, 2025 •
edited
Loading

References and relevant issues

Part of #7705

Description

I think this is skipping the new-ish test that is flaky on windows.
Please feel free to check me on this!!
(getting tired of chain rerunning CI! 😡 )

@github-actions github-actions bot added the tests Something related to our tests label Mar 16, 2025
@psobolewskiPhD psobolewskiPhD added maintenance PR with maintance changes, and removed tests Something related to our tests labels Mar 16, 2025
@github-actions github-actions bot added the tests Something related to our tests label Mar 16, 2025
@psobolewskiPhD psobolewskiPhD added this to the 0.6.0 milestone Mar 16, 2025
@codecov Codecov
Copy link
codecov bot commented Mar 16, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.84%. Comparing base (cb6f6e6) to head (6d21a30).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7709      +/-   ##
==========================================
- Coverage   92.88%   92.84%   -0.04%     
==========================================
  Files         633      633              
  Lines       59430    59433       +3     
==========================================
- Hits        55201    55181      -20     
- Misses       4229     4252      +23

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Czaki Czaki added the ready to merge Last chance for comments! Will be merged in ~24h label Mar 16, 2025
@jni jni merged commit f855de6 into napari:main Mar 17, 2025
41 checks passed
@github-actions github-actions bot removed the ready to merge Last chance for comments! Will be merged in ~24h label Mar 17, 2025
This was referenced Mar 17, 2025
Open
Closed
Merged
jni pushed a commit that referenced this pull request Mar 19, 2025
@psobolewskiPhD
[CI] Update test_vispy_camera.py to skip orientation_2d test on windo…
eb28459 
…ws (#7717)

# References and relevant issues
Despite the previous attempt #7709
still getting windows seg faults:
#7715

# Description
Skip the other orientation test on windows.
Hopefully this solves it?
🤞
Czaki pushed a commit to jni/napari that referenced this pull request Mar 20, 2025
@psobolewskiPhD @Czaki
[CI] Update test_vispy_camera.py to skip orientation_2d test on windo…
ab84b4d 
…ws (napari#7717)

# References and relevant
84F8
 issues
Despite the previous attempt napari#7709
still getting windows seg faults:
napari#7715

# Description
Skip the other orientation test on windows.
Hopefully this solves it?
🤞
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Czaki Czaki Czaki approved these changes

@brisvag brisvag Awaiting requested review from brisvag brisvag is a code owner

@melonora melonora Awaiting requested review from melonora melonora is a code owner

Assignees
No one assigned
Labels
maintenance PR with maintance changes, tests Something related to our tests
Projects
None yet
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@psobolewskiPhD @Czaki @jni
0