8000 Skip `multiple_viewers` example from docs Examples gallery by psobolewskiPhD · Pull Request #7676 · napari/napari · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Skip multiple_viewers example from docs Examples gallery #7676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

psobolewskiPhD
Copy link
Member

References and relevant issues

Recent docs crashes, e.g.: https://github.com/napari/docs/actions/runs/13712919098/job/38379027072?pr=597

Description

The crashes always happen right after this example with a threading warning:
WARNING: QThread: Destroyed while thread is still running
This is also seen when closing viewers, e.g. #7633
So in this PR I skip this example from the Examples gallery -- it's rather boring in the gallery anyways.

@psobolewskiPhD
Copy link
Member Author

@psobolewskiPhD psobolewskiPhD added documentation Documentation content and tooling example Adds or fixes a napari example (core or plugin) DX Developer experience labels Mar 8, 2025
Copy link
Collaborator
@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go for it!

@psobolewskiPhD
Copy link
Member Author
psobolewskiPhD commented Mar 8, 2025

I'm going to re-run Circle a couple times:
https://app.circleci.com/pipelines/github/napari/napari?branch=pull%2F7676

4 straight successes. So I think this fix is real.

Copy link
codecov bot commented Mar 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.84%. Comparing base (838ce4c) to head (9c7d694).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7676      +/-   ##
==========================================
+ Coverage   92.81%   92.84%   +0.03%     
==========================================
  Files         632      632              
  Lines       59259    59259              
==========================================
+ Hits        54999    55019      +20     
+ Misses       4260     4240      -20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@melissawm melissawm added this to the 0.6.0 milestone Mar 8, 2025
Copy link
Member
@melissawm melissawm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's give this a try to unblock CI. Thanks for tracking this down @psobolewskiPhD !

psobolewskiPhD reacted with heart emoji willingc reacted with rocket emoji
@melissawm melissawm added the ready to merge Last chance for comments! Will be merged in ~24h label Mar 8, 2025
@melissawm melissawm merged commit 3adbc07 into napari:main Mar 8, 2025
54 checks passed
@github-actions github-actions bot removed the ready to merge Last chance for comments! Will be merged in ~24h label Mar 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation content and tooling DX Developer experience example Adds or fixes a napari example (core or plugin)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0