8000 Move focus to main window before close `NapariQtNotification` by Czaki · Pull Request #7656 · napari/napari · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Move focus to main window before close NapariQtNotification #7656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

Czaki
Copy link
Collaborator
@Czaki Czaki commented Feb 26, 2025

References and relevant issues

closes #7654

Description

Move focus to the main window before destruction to avoid calling of _focus_changed during destruction

@github-actions github-actions bot added the qt Relates to qt label Feb 26, 2025
Copy link
Contributor
@DragaDoncila DragaDoncila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the issue for me 🎉 Feel free to merge when CI is green

@Czaki Czaki added bugfix PR with bugfix maintenance PR with maintance changes, labels Feb 26, 2025
Copy link
codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.85%. Comparing base (c81efa9) to head (9febb0a).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7656      +/-   ##
==========================================
- Coverage   92.88%   92.85%   -0.04%     
==========================================
  Files         630      630              
  Lines       59066    59067       +1     
==========================================
- Hits        54864    54846      -18     
- Misses       4202     4221      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Czaki Czaki added this to the 0.6.0 milestone Feb 26, 2025
@Czaki Czaki added the ready to merge Last chance for comments! Will be merged in ~24h label Feb 26, 2025
@Czaki Czaki merged commit 68de9b0 into napari:main Feb 27, 2025
50 checks passed
@Czaki Czaki deleted the fix_7654 branch February 27, 2025 06:15
@github-actions github-actions bot removed the ready to merge Last chance for comments! Will be merged in ~24h label Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix PR with bugfix maintenance PR with maintance changes, qt Relates to qt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dismissing a show_info() message exits napari with a segfault
3 participants
0