8000 Set dtype for out of bounds slice when slicing image by Czaki · Pull Request #7606 · napari/napari · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Set dtype for out of bounds slice when slicing image #7606

8000 New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 15, 2025
Merged

Set dtype for out of bounds slice when slicing image #7606

merged 2 commits into from
Feb 15, 2025

Conversation

Czaki
Copy link
Collaborator
@Czaki Czaki commented Feb 14, 2025 •
edited
Loading

References and relevant issues

closes #7601
closes #7604

Description

Search usage does not show the next missed place, so hopefully it is the last fix in this context.

@Czaki Czaki added the bugfix PR with bugfix label Feb 14, 2025
@Czaki Czaki added this to the 0.6.0 milestone Feb 14, 2025
@Czaki Czaki requested a review from psobolewskiPhD February 14, 2025 10:39
@codecov Codecov
Copy link
codecov bot commented Feb 14, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.83%. Comparing base (cd21d36) to head (e6ae88a).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7606      +/-   ##
==========================================
+ Coverage   92.68%   92.83%   +0.15%     
==========================================
  Files         629      629              
  Lines       58839    58839              
==========================================
+ Hits        54536    54626      +90     
+ Misses       4303     4213      -90

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Czaki Czaki changed the title set dtype for out of bounds slice Set dtype for out of bounds slice when slicing image Feb 14, 2025
psobolewskiPhD
psobolewskiPhD approved these changes Feb 14, 2025
View reviewed changes
Copy link
Member
@psobolewskiPhD psobolewskiPhD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the same fix that worked for me locally.
That said I still don't get why empty returns False when this method sets it to True.

@Czaki
Copy link
Collaborator Author
Czaki commented Feb 14, 2025

@psobolewskiPhD Fixed

@Czaki Czaki added the ready to merge Last chance for comments! Will be merged in ~24h label Feb 14, 2025
@Czaki
Copy link
Collaborator Author
Czaki commented Feb 14, 2025

Removing of empty happens here

napari/napari/layers/_scalar_field/scalar_field.py

Line 542 in cd21d36

response = response.to_displayed(self._raw_to_displayed)

@jni jni merged commit 5dc9005 into napari:main Feb 15, 2025
41 checks passed
@jni jni deleted the fix7601 branch February 15, 2025 02:01
@github-actions github-actions bot removed the ready to merge Last chance for comments! Will be merged in ~24h label Feb 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willingc willingc willingc approved these changes

@psobolewskiPhD psobolewskiPhD psobolewskiPhD approved these changes

@brisvag brisvag Awaiting requested review from brisvag brisvag is a code owner

@kephale kephale Awaiting requested review from kephale kephale is a code owner

Assignees
No one assigned
Labels
bugfix PR with bugfix
Projects
None yet
Milestone
0.6.0
4 participants
@Czaki @willingc @psobolewskiPhD @jni
0