Change naming of 'pan/zoom' mode to 'Move camera' to clarify functionality differences in 2D and 3D #7569
8000Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7569 +/- ##
==========================================
- Coverage 92.95% 92.91% -0.04%
==========================================
Files 628 628
Lines 58820 58820
==========================================
- Hits 54676 54655 -21
- Misses 4144 4165 +21 ☔ View full report in Codecov by Sentry. |
| @@ -578,7 +578,7 @@ def _mode_setter_helper(self, mode_in: Union[Mode, str]) -> StringEnum: | |||
|
|
|||
| if mode == TRANSFORM: | |||
| self.help = trans._( | |||
| 'hold <space> to pan/zoom, hold <shift> to preserve aspect ratio and rotate in 45° increments' | |||
| 'hold <space> to move camera, hold <shift> to preserve aspect ratio and rotate in 45° increments' | |||
There was a problem hiding this comment.
BTW, i can't figure out how/when to see this message! Making a note here for further investigation.
There was a problem hiding this comment.
I'm unable to find this message either. From what I understand it should be in the bottom right for the status bar message, but seems to only ever show different tooltips (like when in Transform mode it suggests pressing hotkey to switch to Move camera mode)
There was a problem hiding this comment.
Yeah, I think I've got a lead on the culprit. will make an issue or pr once I've sorted it -- probably not till the weekend though.
There was a problem hiding this comment.
@psobolewskiPhD, I think it shows up when 'Show Layer Tooltips' is ticked on in the settings -- I checked for 10 seconds before leavign the lab. Sorry, sending from my phone at the moment but it popped into my head and didn't want to forget to pass it on.
There was a problem hiding this comment.
Pretty sure layer tooltips are something different.
Try:
python examples/add_labels_with_features.py
And then hover over the labeled coins with that option ticked on or off (it's also in the View menu)
|
I'd like one more core dev to chime in on this before we merge. |
|
We discussed this at last week's Eurasia meeting and were all happy with the change. I'm merging now! Thanks @TimMonko 🎉 |
References and relevant issues
Closes #7467 by clearing up confusion about how to activate and move camera/layer in various circumstances including 2D vs 3D and labels layers. Thank you in particular for additional information @psobolewskiPhD and @brisvag (and for the 'Move camera' suggestion, for which I could not think of anything more appropriate).
I will open a PR to update the name used in the docs if this PR ends up being merged.
Description
Alternatives
qt_layer_controls_base.pyto clarify 2D vs 3D usage