Fix selection of nD-sliced shapes #7459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psobolewskiPhD
approved these changes
Dec 20, 2024
jni
reviewed
Dec 20, 2024
Comment on lines
+1158
to
+1167
| next( | ||
| inside_indices[p] | ||
| for p in pos[::-1] | ||
| if np.any( | ||
| inside_triangles( | ||
| self._visible_shapes[inside_indices[p]][ | ||
| 1 | ||
| ]._all_triangles() | ||
| - coord | ||
| ) |
There was a problem hiding this comment.
Have I mentioned I hate black? Not sure I have... 🤔
😂 😭
jni
approved these changes
Dec 20, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7459 +/- ##
==========================================
- Coverage 92.98% 92.90% -0.08%
==========================================
Files 626 626
Lines 58128 58145 +17
==========================================
- Hits 54048 54022 -26
- Misses 4080 4123 +43 ☔ View full report in Codecov by Sentry. |
925F
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References and relevant issues
closes #7458
Description
This PR closes bug with selecting shapes only from current slice, introduced in #7144.
The source of the bug is not filtering out-of-slice shapes when searching for intersecting triangles.