Enforce minimum side length when guessing if image is RGB #7273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the vast majority of user RGB images, the side length would be larger than 30 pixels. (For reference, our layer thumbnails are 32x32.) Therefore, we can reduce or avoid issues like napari#7261 by enforcing a minimum side length before we use the final dim as an RGB dim.
|
@DragaDoncila I know you don't like this but I do think it's going to be a significant user improvement with limited risk. We can make it a preference in the near future so that users can configure this behaviour to suit their data. |
|
(and turn it off altogether if they don't want us guessing! Adding an action to un-rgb an image would be a good additional fix.) |
We should be able to override the magic guess if rgb is manually set to True.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7273 +/- ##
==========================================
- Coverage 92.84% 92.74% -0.10%
==========================================
Files 623 623
Lines 57114 57127 +13
==========================================
- Hits 53025 52983 -42
- Misses 4089 4144 +55 ☔ View full report in Codecov by Sentry. |
Czaki
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References and relevant issues
Closes #7261
Description
For the vast majority of user RGB images, the side length would be larger than 30 pixels. (For reference, our layer thumbnails are 32x32.) Therefore, we can reduce or avoid issues like #7261 by enforcing a minimum side length before we use the final dim as an RGB dim.
I've implemented this as a parameter on the guess_rgb function, which allows us
to turn this into a preference in the future.