8000 [Maint] Remove some pytest skipif for python <3.9 by psobolewskiPhD · Pull Request #7203 · napari/napari · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[Maint] Remove some pytest skipif for python <3.9 #7203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 20, 2024
Merged

[Maint] Remove some pytest skipif for python <3.9 #7203

merged 1 commit into from
Aug 20, 2024

Conversation

psobolewskiPhD
Copy link
Member

References and relevant issues

While looking at #3404 I noticed that test_theme was skipped for python < 3.9.
Well, we don't support 3.9 anymore and don't run that in our CI matrix.

Description

This PR removes that and another 3.9 skipif in tests.

@psobolewskiPhD psobolewskiPhD requested a review from a team as a code owner August 18, 2024 03:35
@psobolewskiPhD psobolewskiPhD added the maintenance PR with maintance changes, label Aug 18, 2024
@github-actions github-actions bot added the tests Something related to our tests label Aug 18, 2024
@codecov Codecov
Copy link
codecov bot commented Aug 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.68%. Comparing base (bed967f) to head (946323e).
Report is 4 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7203      +/-   ##
==========================================
- Coverage   92.78%   92.68%   -0.10%     
==========================================
  Files         620      620              
  Lines       56797    56792       -5     
==========================================
- Hits        52699    52640      -59     
- Misses       4098     4152      +54

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Czaki Czaki added this to the 0.5.3 milestone Aug 18, 2024
@Czaki Czaki added the ready to merge Last chance for comments! Will be merged in ~24h label Aug 18, 2024
@psobolewskiPhD
Copy link
Member Author
psobolewskiPhD commented Aug 18, 2024 •
edited
Loading

Looking at CI from this, e.g. 3.9 ubuntu (https://github.com/napari/napari/actions/runs/10437542056/job/28912236041?pr=7203)
napari/utils/_tests/test_theme.py ................ [ 204/4237] [0:00:01]
and

============================= slowest 10 durations =============================
  7.83s call    
8000
 napari/_vispy/_tests/test_vispy_labels_layer.py::test_labels_iso_gradient_modes
  6.46s call     napari/_qt/perf/_tests/test_perf.py::test_trace_on_start
  4.47s call     napari/_qt/_tests/test_qt_viewer.py::test_label_colors_matching_widget_auto[int64-all]
  4.31s call     napari/_qt/_tests/test_qt_viewer.py::test_label_colors_matching_widget_auto[int16-selected]
  4.12s call     napari/_qt/_tests/test_qt_viewer.py::test_more_than_uint16_colors
  4.07s call     napari/_qt/_tests/test_qt_viewer.py::test_label_colors_matching_widget_auto[int8-selected]
  3.79s call     napari/_qt/_tests/test_qt_viewer.py::test_label_colors_matching_widget_auto[int16-all]
  3.72s call     napari/_qt/_tests/test_qt_viewer.py::test_label_colors_matching_widget_auto[int8-all]
  3.63s call     napari/_qt/_tests/test_qt_viewer.py::test_label_colors_matching_widget_auto[int64-selected]
  2.94s call     napari/_vispy/_tests/test_image_rendering.py::test_visibility_consistency

So I think we can consider #3404 closed.

@psobolewskiPhD psobolewskiPhD linked an issue Aug 19, 2024 that may be closed by this pull request
Theme testing incredibly slow in CI #3404
Closed
@lucyleeow lucyleeow merged commit 4c30018 into napari:main Aug 20, 2024
46 checks passed
@lucyleeow
Copy link
Contributor

Thanks @psobolewskiPhD

@github-actions github-actions bot removed the ready to merge Last chance for comments! Will be merged in ~24h label Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Czaki Czaki Czaki approved these changes

Assignees
No one assigned
Labels
maintenance PR with maintance changes, tests Something related to our tests
Projects
None yet
Milestone
0.5.3
Development

Successfully merging this pull request may close these issues.

Theme testing incredibly slow in CI
3 participants
@psobolewskiPhD @lucyleeow @Czaki
0