Improve error message in combine_widgets
#7194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7194 +/- ##
==========================================
- Coverage 92.82% 92.73% -0.10%
==========================================
Files 623 623
Lines 56972 56976 +4
==========================================
- Hits 52885 52835 -50
- Misses 4087 4141 +54 ☔ View full report in Codecov by Sentry. |
jni
reviewed
Aug 15, 2024
jni
approved these changes
Aug 15, 2024
combine_widgetscombine_widgets
|
Re-running the failed CI windows PR test, hopefully it was just being flaky earlier |
Czaki
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References and relevant issues
closes #6232
Updates error message to mention
magicgui.widgets.Widget, which we do also support. Although it seems likemagicgui.widgets.Widgetis a subclass ofQWidget, magicgui no longer usesQWidgetdirectly:napari/napari/_qt/utils.py
Lines 227 to 228 in 7099b18
Description
Added test. Although
combine_widgetsis technically innapari/_qt/utilsI've put the test innapari/_qt/widgets/_tests/test_qt_dock_widget.pyas it seems it should sit with the other widget tests.