8000 MNT Parametrize `test_open_files_dialog` to check for `stack` `True` and `False` by lucyleeow · Pull Request #7176 · napari/napari · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

MNT Parametrize test_open_files_dialog to check for stack True and False #7176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

lucyleeow
Copy link
Contributor

References and relevant issues

Follow up to #7172

Description

Parametrizes test to check for stack True and False. I forgot to add this to the original PR, sorry for the extra noise.

@lucyleeow lucyleeow added the maintenance PR with maintance changes, label Aug 10, 2024
@github-actions github-actions bot added tests Something related to our tests qt Relates to qt labels Aug 10, 2024
Copy link
codecov bot commented Aug 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.91%. Comparing base (3c7d1a4) to head (fd41fb5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7176      +/-   ##
==========================================
- Coverage   93.01%   92.91%   -0.10%     
==========================================
  Files         620      620              
  Lines       56763    56765       +2     
==========================================
- Hits        52797    52745      -52     
- Misses       3966     4020      +54     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member
@psobolewskiPhD psobolewskiPhD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Lucy!

@psobolewskiPhD psobolewskiPhD added the ready to merge Last chance for comments! Will be merged in ~24h label Aug 10, 2024
@psobolewskiPhD psobolewskiPhD added this to the 0.5.2 milestone Aug 10, 2024
@Czaki Czaki added ready to merge Last chance for comments! Will be merged in ~24h and removed ready to merge Last chance for comments! Will be merged in ~24h labels Aug 11, 2024
@jni jni merged commit 9c88951 into napari:main Aug 12, 2024
52 checks passed
@github-actions github-actions bot removed the ready to merge Last chance for comments! Will be merged in ~24h label Aug 12, 2024
@lucyleeow lucyleeow deleted the test_file branch August 12, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance PR with maintance changes, qt Relates to qt tests Something related to our tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0