[Maint] Update version_denylist.txt to block mpl 3.9.1 on windows #7154
Conversation
|
@napari-bot update constraints |
…orstore`, `tifffile`, `tqdm`, `xarray`
|
Updated packages: This workflow cannot automatically update your PR or create PR to your repository. But you could open such PR by clicking the link: psobolewskiPhD/napari@block_mpl_391_on_Win...napari-bot:auto-update-dependencies/psobolewskiPhD/napari/block_mpl_391_on_Win. You could also get the updated files from the https://github.com/napari-bot/napari/tree/auto-update-dependencies/psobolewskiPhD/napari/block_mpl_391_on_Win/resources/constraints. Or ask the maintainers to provide you the contents of the constraints artifact from the run https://github.com/napari/napari/actions/runs/10232718937 |
…lewskiPhD/napari/block_mpl_391_on_Win Update `hypothesis`, `napari-plugin-manager`, `npe2`, `pytest`, `tens…
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7154 +/- ##
==========================================
- Coverage 92.97% 92.90% -0.08%
==========================================
Files 619 619
Lines 56729 56729
==========================================
- Hits 52742 52702 -40
- Misses 3987 4027 +40 ☔ View full report in Codecov by Sentry. |
|
How is it possible that it pass when merging constraints files? Did they yank some release? I also think that bumping all constraints in this PR is not a good idea. I think that this change should be reverted and only |
…`, `tensorstore`, `tifffile`, `tqdm`, `xarray`" This reverts commit 8c13b19.
|
My understanding from the issue is that it's windows 3.9.1 wheels specifically that have a bug, which has affected other downstream projects. So they pulled those wheels, which is now affecting us. |
|
This looks in the clear now @Czaki Looks like my constraint update included both the new manager and new npe2, so could be something in one of those? |
|
@Czaki should we just merge this, bypassing 24 hrs, to fix CI and make it easier to debug the issue with pyside? |
|
Fell free to merge imediatelly. |
|
The 3.9 A73A .1 wheels on windows would, depending on import order, cause segfaults, see matplotlib/matplotlib#28551 (comment). We deleted the bad wheels to avoid segfaults (which seemed like a good idea) but failed to anticipate that this would cause downstream projects to start trying to build mpl from source instead of pulling the 3.9.0 wheel. Sorry for the trouble. |
|
Thanks for reaching out! And no worries, shit happens--no need to apologize. |
References and relevant issues
Windows tests are failing due to matplotlib 3.9.1: matplotlib/matplotlib#28551
e.g.:
https://github.com/napari/napari/actions/runs/10232235699/job/28309138502
Edit: the wheels have been pulled from pypi so now tests fail because of build issues.
Description
Adds mpl 3.9.1 on windows to the deny list for our test constraints.