Allow easy call single benchmark #7145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7145 +/- ##
==========================================
- Coverage 92.98% 92.88% -0.11%
==========================================
Files 619 619
Lines 56653 56653
==========================================
- Hits 52677 52620 -57
- Misses 3976 4033 +57 ☔ View full report in Codecov by Sentry. |
|
would be nicer if we didn't neeed to change all the benchmark files. Maybe just have a cli in python -m napari.benchmarks Shapes3DSuite.time_get_value |
|
But what to do with name collisions? File name is part of test identifier. |
But feel free to ignore, not a big deal :) |
|
@brisvag done |
jni
pushed a commit
to napari/docs
that referenced
this pull request
Aug 12, 2024
# References and relevant issues depends on napari/napari#7145 # Description Add documentation on how easy run benchmarks under debugger to easier understand why benchmarks fail. --------- Co-authored-by: Lorenzo Gaifas <brisvag@gmail.com>
Czaki
added a commit
to Czaki/napari
that referenced
this pull request
Sep 6, 2024
In napari#7145 I have implemented option to call benchmarks without using asv (for debug purpose. Hovewer I forgoten about case of benchmarks without any parameters. I also forgot about call of teardown method. This PR is fixing this.
Czaki
added a commit
that referenced
this pull request
Sep 8, 2024
# Description In #7145 I have implemented option to call benchmarks without using asv (for debug purpose). However, I have forgotten about the case of benchmarks without any parameters. I also forgot about the call of teardown method. This PR is fixing this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References and relevant issues
extracted from #7144
Description
This PR allows calling a single benchmark method without whole setup asv. It simplifies debugging.
It is a simple change and may not support all asv options (for example, it does not allow running functional benchmark)
Example call
python napari/benchmarks/benchmark_shapes_layer.py Shapes3DSuite.time_get_value