Add actionlint on CI #7049
Add actionlint on CI #7049
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7049 +/- ##
==========================================
+ Coverage 92.96% 92.99% +0.03%
==========================================
Files 618 618
Lines 56531 56531
==========================================
+ Hits 52552 52569 +17
+ Misses 3979 3962 -17 ☔ View full report in Codecov by Sentry. |
| bash <(curl https://raw.githubusercontent.com/rhysd/actionlint/main/scripts/download-actionlint.bash) | ||
| ./actionlint -color -ignore SC2129 | ||
| shell: bash |
There was a problem hiding this comment.
This is a bit icky (downloading a bash script from main). Maybe put it in its own workflow? Ideally it would be its own action. Also, it should only run when the .github folder is touched?
There was a problem hiding this comment.
This is a official way to do this based on documentation. The script itself is downloading latest release.
Moved to own action,
|
@jni Which milestone? |
|
I think 0.5.1, unless you think it will help work with #7082 and the like 😅 |
|
current fail is unrelated to changes in this PR. I think that we should merge this PR even with |
This adds actionlint from napari/napari#7049 to help prevent errors in GHA workflows. **Update:** @Czaki also fixed the errors found by actionlint and ensured that new docs builds from tags (a) end up in their own folder (rather than dev/), and (b) don't include alpha, beta and rc tags. --------- Co-authored-by: Grzegorz Bokota <bokota+github@gmail.com>
References and relevant issues
To avoid PR like #7033
Description
This PR adds action lint on CI to early detect problems with workflows that are not executed on pull-request trigger.
I first try to do this on pre-commit, but then it will require
gocompiler and will not contain shellcheck.