Set default dtype for empty _ImageSliceResponse
#6552
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6552 +/- ##
==========================================
- Coverage 92.29% 92.25% -0.05%
==========================================
Files 601 601
Lines 53687 53686 -1
==========================================
- Hits 49553 49527 -26
- Misses 4134 4159 +25 ☔ View full report in Codecov by Sentry. |
|
As noted here, I couldn't reproduce on my personal Mac: But I just tested this branch on my work one, that I reported the issue on, and this PR does resolve it. Do we have any other Mac users on Sonoma? I might update my personal Mac over the holidays, so can test again. |
|
It is not strictly related to MacOS Sonoma. I have a similar bug when cherry-picking (when do this on Ubuntu). It looks like the order of events may depend on multiple conditions |
There was a problem hiding this comment.
I don't completely understand the issue described in #6551 and I can't reproduce it either.
But I think this change should be harmless, so approved. I have a small preference for passing through dtype from the layer, but that's needs a more complicated change and I don't think there's much value in it.
* main: Use blobs instead of random integers (napari#6527) Set default dtype for empty `_ImageSliceResponse` (napari#6552) Add creating image from clipboard (napari#6532) Fix check if plugin is available from conda (napari#6545) Fix generation of layer creation functions docstrings (napari#6558) Print a whole stack if throttler is not finished (napari#6549) Update `app-model`, `babel`, `coverage`, `dask`, `fsspec`, `hypothesis`, `imageio`, `ipython`, `lxml`, `magicgui`, `pandas`, `pint`, `psutil`, `pydantic`, `pyqt6`, `pytest-qt`, `tensorstore`, `tifffile`, `virtualenv`, `xarray` (napari#6478) Minimal changes for mlx (and jax) compatibility for Image layers (napari#6553) [pre-commit.ci] pre-commit autoupdate (napari#6528) Moving IntensityVisualizationMixin from _ImageBase to Image (napari#6548)
References and relevant issues
closes #6551
Description
Set default dtype for empty
_ImageSliceResponse