-
-
Notifications
You must be signed in to change notification settings - Fork 446
Run test suite with optional dependencies and fix tests when triangle
is installed
#6488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 07f39e7.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6488 +/- ##
==========================================
- Coverage 92.23% 92.18% -0.06%
==========================================
Files 601 601
Lines 53198 53214 +16
==========================================
- Hits 49069 49057 -12
- Misses 4129 4157 +28 ☔ View full report in Codecov by Sentry. |
jni
approved these changes
Nov 23, 2023
triangle
is installed
Carreau
approved these changes
Nov 23, 2023
kne42
added a commit
to kne42/napari
that referenced
this pull request
Dec 20, 2023
* main: (80 commits) Check in LabelColormap that fewer than 2**16 colors are requested (napari#6540) Fix label color shuffling by also updating colormap size (napari#6460) Add `_block_refresh()` to layers (napari#6525) MNT: Use `partial` in samples menu to avoid leaking (napari#6538) Update performance and reduce memory usage for big Labels layer in direct color mode (napari#6439) Reset single step and decimals on reset range slider in popup (napari#6523) Add copy operator to fix memory benchmarks (napari#6530) Restore quit shortcut (napari#6526) Fix problem with invalidate cache (napari#6520) [pre-commit.ci] pre-commit autoupdate (napari#6505) Pass key event from Main window to our internal mechanism (napari#6419) Typing: Fully type 5 more files (napari#6361) Do not use native dialog for reset shortcuts (napari#6493) Use views rather than CPU-based hashing for 8- and 16-bit Labels data (napari#6467) Add import lint back to CI (napari#6506) Type napari.layers.image helper sub-modules (napari#6499) Bugfix: ensure gamma and opacity are floats (napari#6498) FIX: Remove `None` default from `_remove_dock_widget` (napari#6481) Add testing_extra and optional dependencies when creating constraints (napari#6487) Run test suite with optional dependencies and fix tests when `triangle` is installed (napari#6488) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bugfix
PR with bugfix
maintenance
PR with maintance changes,
task
Tasks for contributors and maintainers
tests
Something related to our tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix test to pass with installed triangle optional dependency by installing optional dependencies with tox.
extracted from #6467