8000 Run test suite with optional dependencies and fix tests when `triangle` is installed by Czaki · Pull Request #6488 · napari/napari · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Run test suite with optional dependencies and fix tests when triangle is installed #6488

8000
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 24, 2023

Conversation

Czaki
Copy link
Collaborator
@Czaki Czaki commented Nov 22, 2023

Fix test to pass with installed triangle optional dependency by installing optional dependencies with tox.

extracted from #6467

@Czaki Czaki added this to the 0.5.0 milestone Nov 22, 2023
@Czaki Czaki added the maintenance PR with maintance changes, label Nov 22, 2023
@github-actions github-actions bot added tests Something related to our tests task Tasks for contributors and maintainers and removed maintenance PR with maintance changes, labels Nov 22, 2023
Copy link
codecov bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (85c58b5) 92.23% compared to head (634337d) 92.18%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6488      +/-   ##
==========================================
- Coverage   92.23%   92.18%   -0.06%     
==========================================
  Files         601      601              
  Lines       53198    53214      +16     
==========================================
- Hits        49069    49057      -12     
- Misses       4129     4157      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jni jni added bugfix PR with bugfix maintenance PR with maintance changes, ready to merge Last chance for comments! Will be merged in ~24h labels Nov 23, 2023
@jni jni changed the title Run test with optional and fix it for triangle dependecy Run test suite with optional dependencies and fix tests when triangle is installed Nov 23, 2023
@Carreau Carreau merged commit 0b89f5b into napari:main Nov 24, 2023
@Carreau Carreau removed the ready to merge Last chance for comments! Will be merged in ~24h label Nov 24, 2023
@Czaki Czaki deleted the fix_polygon_triangles branch November 24, 2023 09:17
kne42 added a commit to kne42/napari that referenced this pull request Dec 20, 2023
* main: (80 commits)
  Check in LabelColormap that fewer than 2**16 colors are requested (napari#6540)
  Fix label color shuffling by also updating colormap size (napari#6460)
  Add `_block_refresh()` to layers (napari#6525)
  MNT: Use `partial` in samples menu to avoid leaking  (napari#6538)
  Update performance and reduce memory usage for big Labels layer in direct color mode (napari#6439)
  Reset single step and decimals on reset range slider in popup (napari#6523)
  Add copy operator to fix memory benchmarks (napari#6530)
  Restore quit shortcut (napari#6526)
  Fix problem with invalidate cache  (napari#6520)
  [pre-commit.ci] pre-commit autoupdate (napari#6505)
  Pass key event from Main window to our internal mechanism (napari#6419)
  Typing: Fully type 5 more files (napari#6361)
  Do not use native dialog for reset shortcuts (napari#6493)
  Use views rather than CPU-based hashing for 8- and 16-bit Labels data (napari#6467)
  Add import lint back to CI (napari#6506)
  Type napari.layers.image helper sub-modules (napari#6499)
  Bugfix: ensure gamma and opacity are floats (napari#6498)
  FIX: Remove `None` default from `_remove_dock_widget` (napari#6481)
  Add testing_extra and optional dependencies when creating constraints (napari#6487)
  Run test suite with optional dependencies and fix tests when `triangle` is installed (napari#6488)
  ...
@Czaki Czaki modified the milestones: 0.5.0, 0.4.19 Dec 27, 2023
Czaki added a commit that referenced this pull request Dec 27, 2023
…e` is installed (#6488)

Fix test to pass with installed triangle optional dependency by installing optional dependencies with tox.

extracted from #6467
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix PR with bugfix maintenance PR with maintance changes, task Tasks for contributors and maintainers tests Something related to our tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0