Minor improvement to qtbot testing section
#481
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry @psobolewskiPhD I want to add some more items. Just didn't get around to it yet. I'll ping you once dine, thank you! |
|
@psobolewskiPhD okay I've tried to add more information but I am not knowledgeable on Qt so please let me know if anything is off! |
Czaki
reviewed
Aug 21, 2024
| <br/> | ||
| ```` | ||
|
|
||
| `qtbot` provides a convenient | ||
| `qtbot` also provides a convenient | ||
| [`addWidget`](https://pytest-qt.readthedocs.io/en/latest/reference.html#pytestqt.qtbot.QtBot.addWidget) |
There was a problem hiding this comment.
Suggested change
| [`addWidget`](https://pytest-qt.readthedocs.io/en/latest/reference.html#pytestqt.qtbot.QtBot.addWidget) | |
| [`add_widget`/`addWidget`](https://pytest-qt.readthedocs.io/en/latest/reference.html#pytestqt.qtbot.QtBot.addWidget) |
There was a problem hiding this comment.
Do you want both or is there one that you prefer? I guess add_widget would be more 'python-ic'?
There was a problem hiding this comment.
Looks okay as both so will leave
There was a problem hiding this comment.
In our test we are using both of them. So I would like to signal that both are valid.
| signals, etc...). See the [`qtbot` docs](https://pytest-qt.readthedocs.io/en/latest/reference.html#pytestqt.qtbot.QtBot) for details. | ||
| This prevents leakage between tests. | ||
| The | ||
| [`waitUntil`](https://pytest-qt.readthedocs.io/en/latest/reference.html#pytestqt.qtbot.QtBot.waitUntil) method is also useful to wait for a desired condition. The example below |
There was a problem hiding this comment.
Suggested change
| [`waitUntil`](https://pytest-qt.readthedocs.io/en/latest/reference.html#pytestqt.qtbot.QtBot.waitUntil) method is also useful to wait for a desired condition. The example below | |
| [`wait_until`/`waitUntil`](https://pytest-qt.readthedocs.io/en/latest/reference.html#pytestqt.qtbot.QtBot.waitUntil) method is also useful to wait for a desired condition. The example below |
|
Thanks @Czaki ! Changes made |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References and relevant issues
Related zulip: https://napari.zulipchat.com/#narrow/stream/212875-general/topic/qtbot.20documentation
Description