Require DP constants and enums in dictionary #729
+1,582
−223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bocchino
reviewed
Jun 6, 2025
| /** The set of type symbols used by the dictionary */ | ||
| dictionaryTypeSymbolSet: Set[Symbol] = Set() | ||
| /** The set of alias type symbols used by the dictionary */ | ||
| dictionaryAliasSymbolSet: Set[Symbol] = Set(), |
There was a problem hiding this comment.
I think we should call this TypeSymbolSet instead of AliasSymbolSet. The type definitions happen to be aliases, but other type definitions are possible, and we may want to add them later.
bocchino
reviewed
Jun 6, 2025
| "FwOpcodeType", | ||
| "FwP 8000 acketDescriptorType", | ||
| "FwTlmPacketizeIdType" | ||
| val impliedAliasTypeUses = List( |
There was a problem hiding this comment.
I think we should call this impliedTypeUses.
bocchino
reviewed
Jun 6, 2025
| ) | ||
| }) | ||
| a <- checkIntegerType(a.dictionaryAliasSymbolSet, "this F Prime framework type must be an alias of an integer type") | ||
| a <- checkIntegerType(a.dictionaryConstantSymbolSet, "this F Prime framework type must be a constant with a value of integer type") |
There was a problem hiding this comment.
Suggested change
| a <- checkIntegerType(a.dictionaryConstantSymbolSet, "this F Prime framework type must be a constant with a value of integer type") | |
| a <- checkIntegerType(a.dictionaryConstantSymbolSet, "this F Prime constant must have an integer type") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Require that the following types are defined and output them to the dictionary:
Aliases
Enums
Constants
Closes #719.
Spec updates are done in nasa/fprime#3692.